task-me
/
application
7
0
Fork 0
Code Pull Requests Releases 1 Wiki Activity
Labels Milestones

CHANGE | instant send text message #40

Merged
Vitalik merged 5 commits from feature/send-text-msg into stage 7 months ago
Conversation 0 Commits 5 Files Changed 24
STRIKE commented 7 months ago
Collaborator

Допрацювання відправки текстових повідомлень.

Допрацювання відправки текстових повідомлень.
STRIKE added 2 commits 7 months ago
STRIKE added 1 commit 7 months ago
Vitalik reviewed 7 months ago
src/managers/chat-message.manager.ts Outdated
_.some(messages, msg => msg.uniqueKey === it.uniqueKey),
)
// delete delivered msgs
Vitalik commented 7 months ago
Owner

з назви метода і так це зрозуміло, видалити

з назви метода і так це зрозуміло, видалити
STRIKE marked this conversation as resolved
Vitalik reviewed 7 months ago
src/managers/chat-message.manager.ts Outdated
})
}
// we can temporary preview message, not compared to his status (delivered or failed with deliver)
Vitalik commented 7 months ago
Owner

видалити цей коментар

видалити цей коментар
STRIKE marked this conversation as resolved
Vitalik reviewed 7 months ago
src/managers/chat-message.manager.ts Outdated
}
}
public async addProcessingMsgs(
Vitalik commented 7 months ago
Owner

я б виділив методи які звязані з фековими повідомленнями в окремий клас

я б виділив методи які звязані з фековими повідомленнями в окремий клас
STRIKE marked this conversation as resolved
Vitalik reviewed 7 months ago
src/managers/chat-message.manager.ts Outdated
encodeProcessingMessages,
)
const updatedMessages = messages.filter(
Vitalik commented 7 months ago
Owner

Ось такі обчислення можнна виносити в приватні методи, щоб код простіше читався

Ось такі обчислення можнна виносити в приватні методи, щоб код простіше читався
STRIKE marked this conversation as resolved
Vitalik reviewed 7 months ago
src/managers/chat-message.manager.ts Outdated
await storageService.set(StorageKey.Messages, value)
}
private async createFakeTextMessage(
Vitalik commented 7 months ago
Owner

а такі методи краще щоб були protected, в крайньому випадку public

а такі методи краще щоб були protected, в крайньому випадку public
STRIKE marked this conversation as resolved
Vitalik reviewed 7 months ago
src/managers/chat-message.manager.ts Outdated
}
private async createFakeTextMessage(
userId: number,
Vitalik commented 7 months ago
Owner

Я б взагалі коннкретно цей метод перетворив у клас FakeTextMessage

типу

export class FakeTextMessage {
  constructor(
    public id: string,
    public chatId: string // etc ...
  ) {}

  static getInstance(param) {
    const uniqueKey = generateId();

    const message = {
      id: generateId(),
      chatId,
      userId,
      type: MessageType.Text,
      isPined: false,
      content: {
        message: text,
        mentionsMessage,
        replyToMessage: undefined,
      },
      createdAt: new Date().toISOString(),
      events: null,
      uniqueKey,
      isFake: true,
    };

    if (mentionsMessage) message.content.mentionsMessage = mentionsMessage;

    if (replyToId) {
      const replyMessage = await this.dbCMRepository.getMessage(
        replyToId.toString()
      );

      if (replyMessage)
        message.content.replyToMessage = _.pick(replyMessage, [
          "id",
          "userId",
          "type",
          "content",
        ]);
    }

    return new FakeTextMessage(message.id, message.chatId//...etc) ;
  }
}
Я б взагалі коннкретно цей метод перетворив у клас FakeTextMessage типу ``` export class FakeTextMessage { constructor( public id: string, public chatId: string // etc ... ) {} static getInstance(param) { const uniqueKey = generateId(); const message = { id: generateId(), chatId, userId, type: MessageType.Text, isPined: false, content: { message: text, mentionsMessage, replyToMessage: undefined, }, createdAt: new Date().toISOString(), events: null, uniqueKey, isFake: true, }; if (mentionsMessage) message.content.mentionsMessage = mentionsMessage; if (replyToId) { const replyMessage = await this.dbCMRepository.getMessage( replyToId.toString() ); if (replyMessage) message.content.replyToMessage = _.pick(replyMessage, [ "id", "userId", "type", "content", ]); } return new FakeTextMessage(message.id, message.chatId//...etc) ; } } ```
STRIKE marked this conversation as resolved
Vitalik reviewed 7 months ago
src/managers/chat-message.manager.ts
public async sendTextMessage(data: ISendTextMessage) {
const account = await this.accountManager.getDbAccount()
if (this.isConnected === 'online') {
Vitalik commented 7 months ago
Owner

можна рознести на два методи sendTextMessageOnline sendTextMessageOffline

можна рознести на два методи sendTextMessageOnline sendTextMessageOffline
STRIKE marked this conversation as resolved
Vitalik reviewed 7 months ago
src/managers/chat-message.manager.ts Outdated
}
public async onNewMessage(message: IChatMessage | IChatMessage[]) {
console.log('on new message from chat-message manager', message)
Vitalik commented 7 months ago
Owner

консоль видалити

консоль видалити
STRIKE marked this conversation as resolved
Vitalik reviewed 7 months ago
src/modules/chats/hooks/use-chat-messages.hook.ts Outdated
message?.chatId?.toString() === chatId.toString() &&
!messagesContainsItem(message?.id)
) {
if (message.uniqueKey) {
Vitalik commented 7 months ago
Owner

це також ркаще внести в окрму функцію, бо зара потрібно розбирати код щоб зрозуміти що саме відбувається в функції

це також ркаще внести в окрму функцію, бо зара потрібно розбирати код щоб зрозуміти що саме відбувається в функції
STRIKE marked this conversation as resolved
STRIKE added 1 commit 7 months ago
Vitalik reviewed 7 months ago
src/modules/chats/hooks/use-chat-messages.hook.ts Outdated
useEffect(() => {
if (chatId) loadItems({ chatId }, true)
console.log(messages)
Vitalik commented 7 months ago
Owner

видалити

видалити
STRIKE marked this conversation as resolved
Vitalik reviewed 7 months ago
src/modules/chats/hooks/use-chat-messages.hook.ts Outdated
const onLoadNew = async (limit?: number) => {
const id = messages[messages.length - 1]?.id
// const id = messages[messages.length - 1]?.id
Vitalik commented 7 months ago
Owner

видалити

видалити
STRIKE marked this conversation as resolved
Vitalik reviewed 7 months ago
src/modules/chats/hooks/use-chat-messages.hook.ts
const id = messages[messages.length - 1]?.id
// const id = messages[messages.length - 1]?.id
await loadNew(limit)
// setTimeout(() => setScrollToId(id), 80)
Vitalik commented 7 months ago
Owner

ваидалити

ваидалити
STRIKE marked this conversation as resolved
Vitalik reviewed 7 months ago
src/services/domain/messages/fake-text-message.service.ts Outdated
replyToId?: number
}
export class FakeTextMessage {
Vitalik commented 7 months ago
Owner

це не сервіс, це по суті dto, можна винести в папку dto або просто в окрему папку core

це не сервіс, це по суті dto, можна винести в папку dto або просто в окрему папку core
STRIKE marked this conversation as resolved
STRIKE added 1 commit 7 months ago
Vitalik merged commit ed9ac6f170 into stage 7 months ago
Vitalik deleted branch feature/send-text-msg 7 months ago
The pull request has been merged as ed9ac6f170.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feature/send-text-msg'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes